On Mon, Jul 30, 2012 at 3:30 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 30 July 2012 16:18, Blue Swirl <blauwir...@gmail.com> wrote: >> I think even this is not fully accurate description of the VGA >> insanity, because if the host display happens to use BGR pixel format >> instead of RGB, there may be more byte shuffling, but not in all >> cases: compare vga_draw_line24() to vga_draw_line32() in >> vga_template.h. > > It seems conceptually the wrong layer to have these be done > by the individual device models (similarly there's a bunch of > pixel twiddling done in hw/pl110_template.h). It would be nicer > if this was done by some generic layer instead so the device > model just said "this is a 32 bit BGR framebuffer"...
Fully agree, but it would be also nice to retain the optimizations somehow to avoid any byte swapping. > > -- PMM
