Marc-André Lureau <[email protected]> writes:
> Reviewed-by: Amit Machhiwal <[email protected]>
> Signed-off-by: Marc-André Lureau <[email protected]>
[...]
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 872920b6482b..4e5d8d9f86e3 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -4258,7 +4258,7 @@ static void virt_machine_class_init(ObjectClass *oc,
> const void *data)
> "Set on/off to enable/disable high
> "
> "memory region for PCI MMIO");
>
> - object_class_property_add(oc, "highmem-mmio-size", "size",
> + object_class_property_add_qapi(oc, "highmem-mmio-size", &size_type_info,
> virt_get_highmem_mmio_size,
> virt_set_highmem_mmio_size,
> NULL, NULL);
> @@ -4266,7 +4266,7 @@ static void virt_machine_class_init(ObjectClass *oc,
> const void *data)
> "Set the high memory region size "
> "for PCI MMIO");
>
> - object_class_property_add(oc, "virtio-mmio-transports", "uint8",
> + object_class_property_add_qapi(oc, "virtio-mmio-transports",
> &uint8_type_info,
scripts/checkpatch.pl gripes
WARNING: line over 80 characters
Easy enough to avoid.
Many more below.
> virt_get_virtio_transports,
> virt_set_virtio_transports,
> NULL, NULL);
[...]