Marc-André Lureau <[email protected]> writes:
> Convert all callers of object_property_add() and
> object_class_property_add() that register struct-typed properties with
> QAPI visitor-based getters/setters to use object_property_add_qapi() and
> object_class_property_add_qapi() instead.
>
> This replaces the manual string type name with a reference to the
> generated QAPITypeInfo constant, enabling QMP introspection to report
> accurate QAPI type information for struct properties. Existing
> getters/setters are preserved unchanged.
>
> The cxl-fmw property type is corrected from "CXLFixedMemoryWindow"
> (not a real QAPI type) to "CXLFixedMemoryWindowOptions".
>
> Signed-off-by: Marc-André Lureau <[email protected]>
> ---
> authz/list.c | 2 +-
> block/throttle-groups.c | 5 +++--
> chardev/char-socket.c | 3 ++-
> hw/core/machine.c | 11 +++++++----
> hw/cxl/cxl-host.c | 4 +++-
> hw/remote/vfio-user-obj.c | 5 +++--
> hw/vfio-user/pci.c | 5 +++--
> target/i386/cpu.c | 11 ++++++++---
> target/i386/kvm/tdx.c | 4 +++-
> target/s390x/cpu-system.c | 4 +++-
> 10 files changed, 36 insertions(+), 18 deletions(-)
>
> diff --git a/authz/list.c b/authz/list.c
> index 363b2ee12c98..ed3d346004c2 100644
> --- a/authz/list.c
> +++ b/authz/list.c
> @@ -128,7 +128,7 @@ qauthz_list_class_init(ObjectClass *oc, const void *data)
> .set = qauthz_list_prop_set_policy,
> ));
>
> - object_class_property_add(oc, "rules", "QAuthZListRule",
> + object_class_property_add_qapi(oc, "rules", &QAuthZListRule_type_info,
> qauthz_list_prop_get_rules,
> qauthz_list_prop_set_rules,
> NULL, NULL);
docs/devel/style.rst (for what it's worth):
In case of function, there are several variants:
* 4 spaces indent from the beginning
* align the secondary lines just after the opening parenthesis of the first
For example:
.. code-block:: c
do_something(x, y,
z);
do_something(x, y,
z);
do_something(x, do_another(y,
z));
Thoughts?
[...]
