On 10/19/2026 9:57 AM, Pierrick Bouvier wrote: > On 10/18/2026 7:26 PM, Alistair Francis wrote: >> On Fri, 2026-10-16 at 16:23 -0700, Pierrick Bouvier wrote: >>> List of helpers: >>> - fadd_s >>> - fsub_s >>> - fdiv_s >>> - fsqrt_s >>> - fadd_d >>> - fsub_d >>> - fdiv_d >>> - fsqrt_d >>> - crc32 >>> - crc32c >>> - raise_exception >>> - wfi >> >> Why not just prefix all helpers? >> >> Alistair >> > > This has been discussed here: > https://lore.kernel.org/qemu-devel/[email protected]/ > > Richard seems ok with it, and I'm waiting for Yonggang to respin it. > Meanwhile, I just used a basic "rename" approach, that we can easily > revert. Given that we are guided by compiler/linker errors, it's a very > low effort to change/revert with a zero percent chance of introducing > any problem. > > If that's too invasive for you, I can also pursue this effort and add > the tcg helper patch directly as part of this series. > Regards, > Pierrick
Took a shot at generic helper renaming with this series: https://lore.kernel.org/qemu-devel/[email protected]/ With it, current patch can be removed from this series. Regards, Pierrick
