On 10/19/2026 6:47 AM, Philippe Mathieu-Daudé wrote: > On 19/10/26 07:52, Brian Cain wrote: >> Download the firmware and run it on the corresponding DSP machine. >> >> The images are third-party binaries, so the tests run only when untrusted >> code is allowed. >> >> Signed-off-by: Brian Cain <[email protected]> >> --- >> tests/functional/hexagon/meson.build | 2 + >> .../hexagon/test_qcom_dsp_firmware.py | 89 +++++++++++++++++++ >> 2 files changed, 91 insertions(+) >> create mode 100755 tests/functional/hexagon/test_qcom_dsp_firmware.py > > >> diff --git a/tests/functional/hexagon/test_qcom_dsp_firmware.py b/ >> tests/functional/hexagon/test_qcom_dsp_firmware.py >> new file mode 100755 >> index 00000000000..86a0628d9f3 >> --- /dev/null >> +++ b/tests/functional/hexagon/test_qcom_dsp_firmware.py >> @@ -0,0 +1,89 @@ >> +#!/usr/bin/env python3 >> +# >> +# Boot the production DSP firmware on the Qualcomm DSP machines >> +# >> +# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> +# >> +# SPDX-License-Identifier: GPL-2.0-or-later >> + >> +from qemu_test import QemuSystemTest, Asset, skipUntrustedTest >> +from qemu_test import wait_for_console_pattern >> + >> + >> +class QcomDspFirmwareTest(QemuSystemTest): >> + """Base class: the firmware is the ELF that -kernel starts >> running.""" >> + >> + REPO = 'https://gitlab.com/kernel-firmware/linux-firmware/-/raw/' \ >> + 'd947e4e8e314e9254a1242dc1a5d9cede2cce33d/qcom' > > 404: Page not found
This URL is incomplete at this point, it's just a folder and not the final file. When concatenating sub paths, like "qcm6490/cdsp.mbn" it works fine. It's confusing to our (qemu functional tests) mind since we are blindly used to see the assets full URL here, instead of it being set in each subtest. @Brian: To follow the existing convention, I would recommend to duplicate full URL between assets following something what is done in: tests/functional/aarch64/test_aspeed_ast2700a2.py It's a bit "Do repeat yourself", but at least it's not surprising. It has also the advantage to be easier to replace url if files are moved at any point. Regards, Pierrick
