Ilya Leoshkevich <[email protected]> writes: > On 10/19/26 21:27, Alex Bennée wrote: >> As with x86_64 we now have the bits to add a KVM gdb test. A couple of >> minor wrinkles need to be handled. >> The first is applying an offset when loading the symbols to take >> into >> account the relocation that happens. >> The other minor wrinkle is the s390x only supports WP_WRITE watch >> points so we skip the other watch point tests lest we get confusing >> messages about failing to insert HW breakpoints. >> Signed-off-by: Alex Bennée <[email protected]> >> Reviewed-by: Marc-André Lureau <[email protected]> >> --- >> v3 >> - add symbol-offset handling >> - limit the watchpoint tests >> - add skipIfMissingEnv("QEMU_TEST_GDB") decorator >> --- >> .../functional/gdb-scripts/kernel_gdb_test.py | 10 ++++++---- >> tests/functional/qemu_test/tuxruntest.py | 4 ++++ >> tests/functional/s390x/test_tuxrun.py | 18 +++++++++++++++++- >> tests/guest-debug/run-test.py | 7 ++++++- >> tests/lcitool/libvirt-ci | 2 +- > > Did you intend to bump this submodule here?
oops - no. I've never figured out the git foo needed to reset submodules automatically on checkout. If you jump branches a lot its invariably out of date. Will fix. > Otherwise: this now works and LGTM. > > Reviewed-by: Ilya Leoshkevich <[email protected]> > > [...] -- Alex Bennée Virtualisation Tech Lead @ Linaro
