In exynos4210_combiner_write(), we rule out "reg_n > 1" before we start doing anything as being an invalid guest access. The default case in the later "switch (reg_n)" is therefore unreachable, because it has explicit cases for 0 and 1. Use g_assert_not_reached() instead of a LOG_GUEST_ERROR.
Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-id: [email protected] --- hw/intc/exynos4210_combiner.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c index 2bdb9a0152c..8d1ed4a4bd2 100644 --- a/hw/intc/exynos4210_combiner.c +++ b/hw/intc/exynos4210_combiner.c @@ -242,10 +242,7 @@ static void exynos4210_combiner_write(void *opaque, hwaddr offset, exynos4210_combiner_update(s, grp_quad_base_n + 3); break; default: - qemu_log_mask(LOG_GUEST_ERROR, - "exynos4210.combiner: unallowed write access at offset 0x" - HWADDR_FMT_plx "\n", offset); - break; + g_assert_not_reached(); } } -- 2.43.0
