Hi Marc-André, > Subject: Re: [PATCH v8 05/18] hw/usb/hcd-ohci: Add an auto-hub property and > leave it off > > > Add auto-hub and leave it off. hw_compat_11_1 turns it on for pci-ohci > > and sysbus-ohci, so an older machine type keeps the hub it has today > > and a guest saved by an older QEMU still loads. > > > > pc87560-ohci is its own PCI front end, not a pci-ohci, so it defines > > the property itself. > > > > A companion OHCI adds its ports to the EHCI bus instead of making one, > > so there the EHCI property decides. > > > > Suggested-by: Gerd Hoffmann <[email protected]> > > Signed-off-by: Jamin Lin <[email protected]> > > Message-ID: <[email protected]> > > --- > > hw/usb/hcd-ohci.h | 1 + > > hw/core/machine.c | 2 ++ > > hw/usb/hcd-ohci-pci.c | 1 + > > hw/usb/hcd-ohci-sysbus.c | 1 + > > hw/usb/hcd-ohci.c | 1 + > > hw/usb/pc87560-ohci.c | 1 + > > 6 files changed, 7 insertions(+) > > > > diff --git a/hw/core/machine.c b/hw/core/machine.c index > > f79337e7d774..22d2b834595a 100644 > > --- a/hw/core/machine.c > > +++ b/hw/core/machine.c > > @@ -47,6 +47,8 @@ GlobalProperty hw_compat_11_1[] = { > > { "pci-ehci-usb", "auto-hub", "on" }, > > { "base-xhci", "auto-hub", "on" }, > > { "pci-uhci-usb", "auto-hub", "on" }, > > + { "sysbus-ohci", "auto-hub", "on" }, > > + { "pci-ohci", "auto-hub", "on" }, > > So it also needs pc87560-ohci, no? >
We can add pc87560-ohci to the table, but it will not set anything. hw_compat_11_1 only applies to a machine type that asks for it, and hppa has no versioned machine type. C3700 is just "C3700". I added the entry and built it: auto-hub still reads false on C3700, so the entry never fires. Thanks, Jamin > -- > Marc-André Lureau <[email protected]>
