Hi, I was too slow on the review before the series got PRd, so I'll submit these preliminary fixes instead. Not included here is a fix for --disable-hexagon-idef-parser being broken with the new stub HMX helpers.
Changes in v2: - Squashed tests into their respective fix patches (Marco) - Added missing file (Marco) Changes in v3: - named-parameter substitution for inline assembly tests (Brian) - Add Instruction::has_pair_dest to find all possible pair producers (Brian, Marco) - Move new-regno patching to the non-HLX path of decode_fill_newvalue_regno() to avoid incorrectly overwriting consumer registers (Marco) Anton Johansson (4): target/hexagon: HLX, preserve scalar :mem_noshuf ordering target/hexagon: HLX, search for .new values in pair high register target/hexagon: Forward return address to HLX load/store helpers linux-user/hexagon: Reset hlx_ctx pointer on cpu clone linux-user/hexagon/target_cpu.h | 1 + target/hexagon/hlx_helper.h | 19 ++++++++++++++++ target/hexagon/insn.h | 1 + target/hexagon/macros.h | 13 +++++++---- target/hexagon/decode.c | 29 +++++++++++++++++++----- target/hexagon/hlx_helper.c | 31 +++++++++++++++++-------- target/hexagon/translate.c | 7 +++--- tests/tcg/hexagon/hlx_assign_conv.c | 35 +++++++++++++++++++++++++++++ tests/tcg/hexagon/hlx_mem.c | 22 ++++++++++++++++++ target/hexagon/gen_trans_funcs.py | 5 +++++ target/hexagon/hex_common.py | 2 ++ 11 files changed, 143 insertions(+), 22 deletions(-) create mode 100644 target/hexagon/hlx_helper.h -- 2.52.0
