On Thu, Nov 12, 2026 at 5:16 PM Anton Johansson <[email protected]> wrote: > > Otherwise, the following packet > > { > L7:6 = combine(L0, L2) > mem(R7) = L7.new > } > > results in mem(R7) being zero-initialized, compared to L6.new which > would correctly write the lower bytes of the pair. > > Compared to scalar and HVX .new instructions, HLX encodes the register > number rather than an offset to the producing instruction + an odd/even > bit. In order to find possible producers which write to register pairs > without the odd/even bit, a Instruction::has_pair_dest field is added > for scalar, HVX, and HLX registers. > > Lastly, we move the new-regno patching in decode_fill_newvalue_regno() > to the non-HLX scalar path to avoid overwriting the consumer L7 with the > base register L6 of the producer destination L7:6. This is safe as the > patching is only required for replacing the scalar offset+odd/even > bit with the actual producer. > > Fixes: ef81d1b047337e81 ("target/hexagon: decode HLX packets and add load and > store") > Signed-off-by: Anton Johansson <[email protected]> > --- > target/hexagon/insn.h | 1 + > target/hexagon/decode.c | 29 +++++++++++++++++++----- > tests/tcg/hexagon/hlx_assign_conv.c | 35 +++++++++++++++++++++++++++++ > target/hexagon/gen_trans_funcs.py | 5 +++++ > target/hexagon/hex_common.py | 2 ++ > 5 files changed, 66 insertions(+), 6 deletions(-) >
Reviewed-by: Marco Liebel <[email protected]>
