On 11/13/26 06:47, Markus Armbruster wrote:
Eric Blake <[email protected]> writes:
On Thu, Nov 12, 2026 at 11:16:24AM -0700, Richard Henderson wrote:
On 11/10/26 19:51, Eric Blake wrote:
The following changes since commit 723622bedb0b423de7d1c61ebbe6e7a71934949c:
A few bug fixes:
- Guillaume Vincke: improve connection retry if NBD client hangs up quickly
- Eric Blake: fix two low-severity CVEs with non-compliant NBD clients
New failure:
https://gitlab.com/qemu-project/qemu/-/jobs/17979973534#L298
137/150 block-qcow2-optional+block-slow - qemu:io-qcow2-nbd-stale-connection
FAIL 2.37s exit status 1
{"error": {"class": "GenericError", "desc": "write failed: Input/output
error"}}
Shoot - looks like this hit the CI timeout despite our best efforts,
which is why Guillaume is working on a second series for making the
test more robust [1], although our initial take was that it is really
late in the 11.2 cycle to be adding a new x-debug- QMP command. I can
respin the pull request to drop the test and/or give it a longer
timeout so it is less likely to be flaky in CI.
[1] https://lists.gnu.org/archive/html/qemu-devel/2026-11/msg01941.html
Markus, what are your thoughts on a QMP addition this late into 11.2
so that the test in 2/8 can be stable? I'm torn on whether the NBD bug
in 1/8 is severe enough to need to go in 11.2.0 proper, or whether the
bug is weak enough that it is safer to wait until 11.2.1 via the
qemu-stable process. Patches 3-8 fix CVEs, so they definitely belong
in 11.2.
"Only bug fixes" since soft freeze. The closer we get to the release,
the more serious the bugs need to be.
Including tests with the bug fixes feels okay to me. Test
infrastructure in QEMU proper, like a QMP command, is pushing it,
though.
What's the impact of omitting or disabling the troublesome test until
after the release?
In my opinion, the 1/8 fix and the associated 2/8 test can be postponed
to the next release. That behavior has been there for a long time and,
as far as I know, nobody but me has complained about it. Taking the
time to get a robust test in is probably the safer option.