On Tue, 14 Aug 2012 14:45:17 -0500 Anthony Liguori <aligu...@us.ibm.com> wrote:
> Luiz Capitulino <lcapitul...@redhat.com> writes: > > > On Tue, 14 Aug 2012 08:32:31 -0500 > > Anthony Liguori <aligu...@us.ibm.com> wrote: > > > >> To be replaced with live block copy. > >> > >> Signed-off-by: Anthony Liguori <aligu...@us.ibm.com> > >> --- > >> migration.c | 9 +++++++++ > >> 1 files changed, 9 insertions(+), 0 deletions(-) > >> > >> diff --git a/migration.c b/migration.c > >> index 653a3c1..babccf4 100644 > >> --- a/migration.c > >> +++ b/migration.c > >> @@ -482,10 +482,19 @@ void qmp_migrate(const char *uri, bool has_blk, bool > >> blk, > >> MigrationParams params; > >> const char *p; > >> int ret; > >> + static bool suppress_deprecation_message; > >> > >> params.blk = blk; > >> params.shared = inc; > >> > >> + if (blk && !suppress_deprecation_message) { > >> + qerror_report(ERROR_CLASS_GENERIC_ERROR, > >> + "Block migration is deprecated. " > >> + "See http://wiki.qemu.org/Features/LiveBlockCopy " > >> + "for an alternative syntax."); > > > > Why not error_set()? > > Because we fall through (we don't fail). This is just a warning. > > If you error_set(), then the migration command fails. We don't want it > to fail. > > I guess qerror_report will do that too :-( > > I'll change it to an fprintf :-(( Yes, I'd also add a monitor_printf() call to hmp_migrate() and a note to the schema.