On 09/03/2012 07:33 PM, Paolo Bonzini wrote: > Il 03/09/2012 18:30, Avi Kivity ha scritto: >>>>>> The values above are what every user of the PIC cascaded on our targets >>>>>> >>> > must program to use them. So We will find them in the state once >>>>>> >>> > any >>>>>> >>> > relevant guest code was able to run (e.g. the BIOS). >>>>>> >>> > >>>> >> Suppose the bios has not run yet? >>> > >>> > Then you transmit the subsection. >> And the migration fails. Needlessly, since icw3 == 0 doesn't affect >> guest operation. > > But the point of subsections is to succeed migration in the common case, > assuming there is more than one case that doesn't affect guest operation.
According to the patch, if icw3 == 4 && !(eclr & 4), then behaviour will change. With the standard configuration, if two pci interrupts hit at once, then before the patch irr.2 will be clear, and afterwards set. So we do have a behavioural change. Is the rest of the code masking this change under the standard configuration? -- error compiling committee.c: too many arguments to function
