Am 18.09.2012 01:36, schrieb Peter Crosthwaite: > On Tue, Sep 18, 2012 at 1:13 AM, Andreas Färber <afaer...@suse.de> wrote: >> Am 17.09.2012 10:47, schrieb Peter A. G. Crosthwaite: >>> @@ -80,7 +81,8 @@ xilinx_axiethernetdma_init(DeviceState *dev, StreamSlave >>> *peer, >>> Error *errp = NULL; >>> >>> qdev_prop_set_uint32(dev, "freqhz", freqhz); >>> - object_property_set_link(OBJECT(dev), OBJECT(peer), "tx_dev", &errp); >>> + object_property_set_link(OBJECT(dev), OBJECT(peer), >>> "axistream-connected", >>> + &errp); >>> assert_no_error(errp); >>> qdev_init_nofail(dev); >>> >> >> Indentation of &errp looks odd despite no tabs - intentional? >> > > I have indented to the first multiple of 4 spaces after the function > opening brace. Is there a prescribed way? Can it be added to > CODING_STYLE and checkpatch if there is a particular recommended way?
The usual convention is to align with the opening brace (i.e., 3 spaces less), or if the function name or string argument is too long I believe one 4-spaces indent from the block. Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg