Re: [Qemu-devel] [PATCH 09/14] i386: do not call helper to compute ZF/SF

[Paolo Bonzini]

Il 09/10/2012 21:16, Richard Henderson ha scritto:
>> > +        int size = (s->cc_op - CC_OP_ADDB) & 3;
>> > +        gen_ext_tl(reg, cpu_cc_dst, size, false);
>> > +        tcg_gen_setcondi_tl(TCG_COND_EQ, reg, cpu_cc_dst, 0);
> I take that back.  Should be (EQ, reg, reg, 0) here;
> you've dropped the extension on the floor.

More precisely it should be:

        TCGv t0 = gen_ext_tl(reg, cpu_cc_dst, size, false);
        tcg_gen_setcondi_tl(TCG_COND_EQ, reg, t0, 0);

and similarly for SF.

Paolo