> -----Original Message----- > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > Sent: Thursday, November 15, 2012 6:04 AM > To: Johnson, Eric > Cc: 陳韋任 (Wei-Ren Chen); qemu-devel@nongnu.org; qemu-triv...@nongnu.org; > che...@cs.nctu.edu.tw; Jia Liu > Subject: Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major > opcode > > On Thu, Nov 15, 2012 at 02:34:31AM +0000, Johnson, Eric wrote: > > Hi Chen, > > > > Please only remove the POOL48A opcode. > > > > The others are documented in the microMIPS64 Instruction Set manual ( > http://www.mips.com/secure-download/index.dot?product_name=/auth/MD00087- > 2B-MIPS64BIS-AFP-03.51.pdf ). See > http://www.mips.com/products/architectures/mips64/ for other relavent > docs. > > > > Instead of removing them please surround the POOL32S, DADDIU32, SD32, > and LD32 opcodes with > > #if defined(TARGET_MIPS64) > > > > I don't think a #if is necessary there, this makes the code more > difficult to read, while it doesn't change anything on the generated > code.
Agreed. -Eric
