On 21/11/12 13:07, Igor Mitsyanko wrote: > This version of patch doesn't change anything for majority of machines, its > just that later we can > choose ourself which default block interface to use. So, nothing to review > from Exynos point of view, but patch > is OK, except realview_pb_a8 part (see bellow): > > Acked-by: Igor Mitsyanko <i.mitsya...@samsung.com> > > > On 11/20/2012 06:30 PM, Christian Borntraeger wrote: > >> @@ -379,13 +379,14 @@ static QEMUMachine realview_pb_a8_machine = { >> .name = "realview-pb-a8", >> .desc = "ARM RealView Platform Baseboard for Cortex-A8", >> .init = realview_pb_a8_init, >> + .block_default_type = IF_SCSI, >> }; >> > > > I think that's an unintentional change?
Indeed. Kevin, Stefan, in case of no other findings, can you fix that hunk yourself or do you want a new patch? Christian