On Fri, 2012-12-07 at 16:14 +0000, Ian Jackson wrote: > + target_phys_addr_t offset = (target_phys_addr_t)req->size * i; > + if (req->df) addr -= offset; > + else addr -= offset;
One of these -= should be a += I presume? [...] > + write_phys_req_item((target_phys_addr_t) req->data, req, i, > &tmp); This seems to be the only one with this cast, why? write_phys_req_item takes a target_phys_addr_t so this will happen regardless I think. Ian.
