Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move"): > On Fri, 7 Dec 2012, Ian Jackson wrote: ... > > + if (req->df) addr -= offset; > > + else addr -= offset; > > This can't be right, can it?
Indeed not. v2 has this fixed. > The search/replace changes below look correct. Thanks. > For the sake of consistency, could you please send a patch against > upstream QEMU to qemu-devel? The corresponding code is in xen-all.c > (cpu_ioreq_pio and cpu_ioreq_move). I will do that. Thanks, Ian.