On Tue, Dec 18, 2012 at 12:40:36PM +0100, Paolo Bonzini wrote: > >> ... besides, this only works if the reset callback of > >> vdev->binding_opaque remembers to call virtio_reset (in the s390 > >> bindings, it doesn't and this series fixes it). > > > > That's a separate bug I think. > > Yes, I agree. > > Paolo
Anyway, I think the only argument is about a bit of code duplication, we can fix it up later. Andreas Färber pointed out what looks like a buglet in this patchset, were you going to repost a fixed one?