Am 16.01.2013 11:10, schrieb Paolo Bonzini: > Il 16/01/2013 06:27, Andreas Färber ha scritto: >> Am 10.01.2013 15:40, schrieb Paolo Bonzini: >>> virtio-s390 devices are not being reset when their bus is. To fix >>> this, add a reset method that forwards to virtio_reset. This is >>> only needed because of the "strange" modeling of virtio devices; >>> the ->vdev link is being handled manually rather than through qdev. >>> >>> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> >>> --- >>> hw/s390-virtio-bus.c | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c >>> index 7e99175..1e3e4f0 100644 >>> --- a/hw/s390-virtio-bus.c >>> +++ b/hw/s390-virtio-bus.c >>> @@ -505,6 +505,13 @@ static int s390_virtio_busdev_init(DeviceState *dev) >>> return _info->init(_dev); >>> } >>> >>> +static void s390_virtio_busdev_reset(DeviceState *dev) >>> +{ >>> + VirtIOS390Device *_dev = (VirtIOS390Device *)dev; >> >> Underscore alert. ;) What about naming the arg d and the variable dev? > > True, but the file uses this convention throughout.
Then I'm beginning to understand why Fred's patchset is so large... Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg