On 23 January 2013 15:25, Andreas Färber <afaer...@suse.de> wrote:
> Am 23.01.2013 14:41, schrieb Peter Maydell:
>> On 23 January 2013 13:38, Andreas Färber <afaer...@suse.de> wrote:
>>> Am 23.01.2013 14:03, schrieb Peter Maydell:
>>>> On 23 January 2013 12:07, Andreas Färber <afaer...@suse.de> wrote:
>>>>> + if (cpu_model == NULL) {
>>>>> + return NULL;
>>>>> + }
>>>>
>>>> explicit "== NULL" is kind of ugly; established style in
>>>> target-arm/ is "if (!cpu_model)..."
>>>
>>> I consistently use !foo only if foo is bool. Any decent compiler will
>>> optimize this appropriately.
>>
>> Yes -- I prefer (!ptr) not because I think the code will be different
>> but because I think it is better style (and consistent with the
>> current code -- there are no instances of "== NULL" in target-arm
>> today).
>
> Please see style-changed version here:
> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-types
> https://github.com/afaerber/qemu-cpu/commit/726554290fa69425d0e94e2e4fd2fdfeeb54e00c
Thanks.
Acked-by: Peter Maydell <peter.mayd...@linaro.org>
for the arm related patches in this series.
-- PMM
