On 25 March 2013 01:01, Peter Crosthwaite <peter.crosthwa...@xilinx.com> wrote: > On Sun, Mar 24, 2013 at 9:32 PM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> Comments in the QEMU source code claim that the version of the PCI >> controller on the VersatilePB board doesn't support the PCI I/O >> region, but this is incorrect; expose that region, map it in the >> correct location, and drop the misleading comments. >> >> This change removes the only currently implemented difference >> between the realview-pci and versatile-pci models; however there >> are other differences in not-yet-implemented functionality, so we >> retain the distinction between the two device types.
>> @@ -85,10 +85,8 @@ static int pci_vpb_init(SysBusDevice *dev) >> memory_region_init_io(&s->mem_config2, &pci_vpb_config_ops, bus, >> "pci-vpb-config", 0x1000000); >> sysbus_init_mmio(dev, &s->mem_config2); >> - if (s->realview) { > > This is the one and only usage of ->realview. I wonder if this > argument is flawed - in real hardware is there any functional > difference between realview and versatile PCI requiring the level of > heirachy defined here? Please read the commit message and the later patches in the series :-) thanks -- PMM