On 05/07/2013 10:56 AM, Laszlo Ersek wrote: > In Windows guests this may make a difference. > > Suggested-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > qga/commands-posix.c | 22 ++++++++++++++++------ > 1 files changed, 16 insertions(+), 6 deletions(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index 04c6951..2eec712 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c
Oh, and only NOW do I notice that this is in a file named commands-posix.c that doesn't get compiled into the Windows build of qga (there, we only build commands-win32.c, and THAT file always fails this command, because no one has ported guest-file-open there yet). But I guess there is still the argument that some weirdnix system exists that isn't quite POSIX compliant and does have a distinct binary mode (maybe someone plans on compiling qga for Cygwin instead of native windows, since at least that would be able to open files when the commands-win32.c variant doesn't?), so I still think the patch is worth keeping. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
