On 7 May 2013 18:27, Eric Blake <ebl...@redhat.com> wrote: > On 05/07/2013 10:56 AM, Laszlo Ersek wrote: >> In Windows guests this may make a difference. >> >> Suggested-by: Eric Blake <ebl...@redhat.com> >> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
> Oh, and only NOW do I notice that this is in a file named > commands-posix.c that doesn't get compiled into the Windows build of qga > (there, we only build commands-win32.c, and THAT file always fails this > command, because no one has ported guest-file-open there yet). But I > guess there is still the argument that some weirdnix system exists that > isn't quite POSIX compliant and does have a distinct binary mode (maybe > someone plans on compiling qga for Cygwin instead of native windows, > since at least that would be able to open files when the > commands-win32.c variant doesn't?), so I still think the patch is worth > keeping. If we accept this we should at a minimum update the commit message to say that we're doing this for theoretical completeness rather than any practical reason. (Not that "this may make a difference" is a particularly convincing commit message in the first place :-)) thanks -- PMM