On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote: > The Abort action can be used to test QMP 'transaction' failure. Add it > as the last action to exercise the .abort() and .cleanup() code paths > for all previous actions. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > blockdev.c | 15 +++++++++++++++ > qapi-schema.json | 11 ++++++++++- > 2 files changed, 25 insertions(+), 1 deletion(-)
I like it! Even though libvirt will never use it, I can see how having
it definitely helps development of other transaction actions.
> +++ b/qapi-schema.json
> @@ -1630,6 +1630,14 @@
> '*mode': 'NewImageMode', '*speed': 'int' } }
>
> ##
> +# @Abort
> +#
> +# This action can be used to test transaction failure.
> +###
> +{ 'type': 'Abort',
> + 'data': { } }
> +
Probably should add a Since: 1.6 notation. With that,
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
