Am 05.06.2013 13:10, schrieb Michael S. Tsirkin: > On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote: >> Am 04.06.2013 20:51, schrieb Paolo Bonzini: >>> This series changes all PCI devices (the sole to support hotplug >>> _and_ use MemoryRegions) to do memory_region_del_subregion at >>> unrealize time, and memory_region_destroy at instance_finalize >>> time. >> >> The general idea looks good. >> >> Could you please follow-up with a patch that switches from exit to >> unrealize? > > What do you guys think about changing the name to something > else e.g. "free" or "destroy"?
I'm not generally opposed to renaming things, but current unrealize is a pair with realize, and destroy or free doesn't really fit it's purpose - that's instance_finalize. Let's CC Anthony. Andreas > > unrealize is not a word in english: > http://dictionary.cambridge.org/spellcheck/american-english/?q=unrealize > > I can do it easily if people agree. > >> use BUS(), PCI_DEVICE() etc. to hide this. >> >> Andreas >> >> -- >> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany >> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
