Hi Andreas, On Mon, Jun 10, 2013 at 9:49 PM, Andreas Färber <afaer...@suse.de> wrote: > Am 10.06.2013 12:23, schrieb Peter Crosthwaite: >> Ping! >> >> Any objections to this one going in? perhaps even via trivial queue? > > No strong objection, but you are using an unusual 12-char indentation in > some places that you may want to check. >
I use that indentation when a ? : operator continues to the next line. What indentation scheme should be used in this instance? Regards, Peter > Otherwise the cosmetic cleanup looks fine to me. > > Cheers, > Andreas > >> On Mon, Jun 3, 2013 at 3:11 PM, <peter.crosthwa...@xilinx.com> wrote: >>> From: Peter Crosthwaite <peter.crosthwa...@xilinx.com> >>> >>> Some cosmetics, refactored to use util/fifo8 for the FIFO8, then >>> factored out some common code. >>> >>> Tested as working on petalogix-ml605 machine model + Linux (has >>> coverage of serial fifo usage). >>> >>> >>> Peter Crosthwaite (3): >>> char/serial: cosmetic fixes. >>> char/serial: Use generic Fifo8 >>> char/serial: serial_ioport_write: Factor out common code >>> >>> hw/char/serial.c | 128 >>> +++++++++++++++++++---------------------------- >>> include/hw/char/serial.h | 15 ++---- >>> 2 files changed, 56 insertions(+), 87 deletions(-) >>> >>> -- >>> 1.8.3.rc1.44.gb387c77.dirty >>> >> > > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >
