On Wed, Jul 03, 2013 at 04:34:20PM +0200, Paolo Bonzini wrote: > diff --git a/qemu-img.c b/qemu-img.c > index f8c97d3..857e2ca 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -2073,6 +2073,10 @@ static int img_rebase(int argc, char **argv) > > /* If the cluster is allocated, we don't need to take action */ > ret = bdrv_is_allocated(bs, sector, n, &n); > + if (ret < 0) { > + error_report("error while reading from file"); > + goto out; > + }
We should print the errno valid and saying "while reading from file" is a little misleading: "error while checking cluster allocation status: %d", ret