Jan Kiszka <jan.kis...@web.de> wrote: > This partly reverts 2be3783328: First, the conversion neglected to > update the opaque translation in fdc_pre_save/fdc_post_load which causes > memory corruptions on vmsave/restore. And second, we can't apply a > common translation here as DeviceState->fdctrl_t is different for sysbus > and ISA.
I finished today the proper patch. Please don't apply this one. > Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> > --- > > hw/fdc.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > *** NOTE *** > 'git shortlog|grep "reset + vmsd"' shows 10 such conversions. I only > briefly checked the first one, and it looks similar broken. Could > someone have a second look at them? Maybe it is also better to define a > vmsd opaque in DeviceInfo, which would also allow to solve this issue > differently. It looks like a plan. I am in the middle of trying to get migration working, and have at least another 2 patches (appart from the one already in staging). I am in the last round of testing. Later, Juan.
