Juan Quintela wrote: > Jan Kiszka <jan.kis...@web.de> wrote: >> *** NOTE *** >> 'git shortlog|grep "reset + vmsd"' shows 10 such conversions. I only >> briefly checked the first one, and it looks similar broken. Could >> someone have a second look at them? Maybe it is also better to define a >> vmsd opaque in DeviceInfo, which would also allow to solve this issue >> differently. >> > > I searched for .qdev.vmsd, and all the other uses are right as far as I > can see.
Maybe it works, but it doesn't look clean to me. E.g. tcx.c, vmstate_tcx_post_load: it should be called with the DeviceState as opaque value, right? Then I'm missing container_of(d, TCXState, busdev.qdev). Jan
signature.asc
Description: OpenPGP digital signature
