On Mon, 2013-07-22 at 10:20 +1000, Alexey Kardashevskiy wrote: > May be. But there was no way to get this callback called till I started > calling scsi_req_cancel in this patch so I would not split.
You probably still should. The smaller each individual patch, the better (in part because that makes them easier to review). So a first patch adding the new callback, then a second patch adding the task management. Cheers, Ben.