On 07/22/2013 04:30 PM, Paolo Bonzini wrote: > Il 22/07/2013 03:04, Benjamin Herrenschmidt ha scritto: >> The free_request callback >> is not directly "linked" to task management though it happens to only >> be called in that case. It's a pre-requisite to task management, make it >> a separate patch. > > Ben is right, in fact I'm not sure why you need free_request at all > (since vscsi_put_req is called from both vscsi_command_complete and > vscsi_request_cancelled). > > free_request is only needed by hw/usb/dev-uas.c because it does > scsi_req_ref/scsi_req_unref in the HBA code. There is no need for this, > AFAIK, in the current spapr_vscsi code; if it is done in the > reorganization patches, the free_request callback should be added there.
Hmmm. It looks like you're right :-/ I am just not very familiar with this stuff yet so some misunderstanding is expected :) For now I cannot find really good testing sequence. I do some delay hacks in various places but I am not sure I am testing what I want to test as "req->enqueued" is always false when I debug task management. -- Alexey
