Am 21.08.2013 07:44, schrieb Stefan Weil: > Compiler option -Wextra enables an additional set of compiler warnings. > > Some of these warnings were already enabled explicitly in QEMU: > -Wold-style-declaration, -Wtype-limits, -Wignored-qualifiers and > -Wempty-body are now redundant and can be removed. > > Others don't work with the current code and must be disabled to > avoid warnings: -Wno-missing-field-initializers, -Wno-override-init, > -Wno-sign-compare and -Wno-unused-parameter. > > Signed-off-by: Stefan Weil <s...@weilnetz.de> > --- > This is a rather old and long tested patch: I use -Wextra in my > QEMU builds for more than a year now. At least one bug was found > by using this warning level (see commit > b22dd1243f38286263d40496ce5298a8a7d96eea). > > My tests include Linux and Windows hosts (gcc), but not BSD based hosts, > so maybe those hosts might need additional code fixes. > clang reports lots of -Wunused-value warnings. > > Regards, > Stefan > > configure | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-)
Ping? I'd appreciate getting this patch committed. Is it trivial enough for qemu-trivial? Stefan See also http://patchwork.ozlabs.org/patch/268687/
