On 15 September 2013 18:30, Michael S. Tsirkin <m...@redhat.com> wrote:
> On Sun, Sep 15, 2013 at 07:16:41PM +0300, Marcel Apfelbaum wrote:
>> +static const MemoryRegionOps master_abort_mem_ops = {
>> + .read = master_abort_mem_read,
>> + .write = master_abort_mem_write,
>> + .endianness = DEVICE_NATIVE_ENDIAN,
>> +};
>> +
>
> Please make it little endian.
> DEVICE_NATIVE_ENDIAN is almost always a bug.
...when dealing with PCI devices. For a random device on the system bus
it's often correct.
-- PMM
