On Fri, Aug 16, 2013 at 03:18:27PM +0200, arm...@redhat.com wrote: > From: Markus Armbruster <arm...@redhat.com> > > This gets rid of one of the last get_param_value() users, makes > multiple -smbios work sanely, cleans up the gross side effect in > qemu_uuid_parse(), and more. Topped off with a little feature in the > last patch. > > v2: Rebase, only last patch had conflicts
OK my thinking at this point is: patches 1-6 are ready Any objections? patch 7 - I would prefer some way to explicitly set default smbios manufacturer/version in machine type and set these from machine type, instead of the smbios_type1_defaults boolean. Would you like - me to apply 1-6 and keep working on 7? - wait for you to repost v3? - look for another maintainer to take patchset as is (if someone cares to, I won't object)? > Markus Armbruster (7): > smbios: Normalize smbios_entry_add()'s error handling to exit(1) > smbios: Convert to QemuOpts > smbios: Improve diagnostics for conflicting entries > smbios: Make multiple -smbios type= accumulate sanely > smbios: Factor out smbios_maybe_add_str() > vl: Set current_machine early > smbios: Set system manufacturer, product & version by default > > arch_init.c | 9 +- > hw/i386/pc.c | 6 +- > hw/i386/pc_piix.c | 5 + > hw/i386/pc_q35.c | 3 + > hw/i386/smbios.c | 349 > ++++++++++++++++++++++++++++++++------------- > include/hw/i386/pc.h | 1 + > include/hw/i386/smbios.h | 7 +- > include/sysemu/arch_init.h | 2 +- > include/sysemu/sysemu.h | 1 + > vl.c | 8 +- > 10 files changed, 276 insertions(+), 115 deletions(-) > > -- > 1.8.1.4 >
