Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command

[Paolo Bonzini]

Il 20/09/2013 13:54, Kevin Wolf ha scritto:
> +     * For now, simply forbidding the combination for all drivers will do. */
> +    if (options->has_aio && options->aio == BLOCKDEV_A_I_O_OPTIONS_NATIVE) {

Let's call it BlockdevAioOptions instead?

Paolo


> +        bool direct = options->cache->has_direct && options->cache->direct;
> +        if (!options->has_cache && !direct) {
> +            error_setg(errp, "aio=native requires cache.direct=true");