Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command

[Paolo Bonzini]

Il 20/09/2013 16:01, Benoît Canet ha scritto:
>> > +    if (error_is_set(&local_err)) {
>> > +        error_propagate(errp, local_err);
>> > +        goto fail;
> There is nothing to execute between error_propagate and fail: maybe we could
> get rid of the goto.

Or perhaps of the "else".

Paolo

>> > +    } else {
>> > +        dinfo = blockdev_init(opts, IF_NONE);
>> > +        if (!dinfo) {
>> > +            error_setg(errp, "Could not open image");
>> > +            goto fail;
> Same.
>> > +        }
>> > +    }