On 8 October 2013 00:54, Petar Jovanovic <petar.jovano...@rt-rk.com> wrote: > From: Petar Jovanovic <petar.jovano...@imgtec.com> > > Structs ipc_perm and shmid_ds are specific for each architecture and should > be defined accordingly. This change does that, and it also fix shmctl issue > by passing correct parameter buf to do_shmctl().
Please can you separate out these two things into separate patches? It's much harder to review the code changes for the do_shmctl changes when they're swamped by the code motion for making the structs per-arch. > Signed-off-by: Petar Jovanovic <petar.jovano...@imgtec.com> > --- > linux-user/syscall.c | 78 +++++++---------- > linux-user/syscall_defs.h | 211 > +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 240 insertions(+), 49 deletions(-) Rather than adding another big ifdef ladder to syscall_defs.h, I think we should create a new file linux-user/$arch/target_structs.h for each target arch as a place to put "depends on the architecture" struct definitions. We could then clean up some of the ifdef ladders in the existing syscall_defs.h too... thanks -- PMM
