On Wed, Dec 02, 2009 at 01:04:27PM +0100, Juan Quintela wrote: > And they were saved/loaded as unsigned already
I'm not sure how does on save/load a value as unsigned. Could you please provide motivation for this and similar changes? Not that it matters very much, but int is slightly cleaner than uint32_t for something that is only 1 or 0. > Signed-off-by: Juan Quintela <quint...@redhat.com> > --- > hw/virtio-net.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/virtio-net.c b/hw/virtio-net.c > index 05cc67f..589ea80 100644 > --- a/hw/virtio-net.c > +++ b/hw/virtio-net.c > @@ -50,8 +50,8 @@ typedef struct VirtIONet > uint8_t nouni; > uint8_t nobcast; > struct { > - int in_use; > - int first_multi; > + uint32_t in_use; > + uint32_t first_multi; > uint8_t multi_overflow; > uint8_t uni_overflow; > uint8_t *macs; > @@ -715,7 +715,7 @@ static void virtio_net_save(QEMUFile *f, void *opaque) > qemu_put_be16s(f, &n->status); > qemu_put_8s(f, &n->promisc); > qemu_put_8s(f, &n->allmulti); > - qemu_put_be32(f, n->mac_table.in_use); > + qemu_put_be32s(f, &n->mac_table.in_use); > qemu_put_buffer(f, n->mac_table.macs, n->mac_table.in_use * ETH_ALEN); > qemu_put_buffer(f, n->vlans, MAX_VLAN >> 3); > qemu_put_be32(f, n->has_vnet_hdr); > @@ -756,7 +756,7 @@ static int virtio_net_load(QEMUFile *f, void *opaque, int > version_id) > } > > if (version_id >= 5) { > - n->mac_table.in_use = qemu_get_be32(f); > + qemu_get_be32s(f, &n->mac_table.in_use); > qemu_get_buffer(f, n->mac_table.macs, > n->mac_table.in_use * ETH_ALEN); > } > -- > 1.6.5.2