On Fri, 04 Dec 2009 12:17:51 +0100 Gerd Hoffmann <kra...@redhat.com> wrote:
> On 12/04/09 01:04, Anthony Liguori wrote: > > Problem is, control is not a property of the character device. To > > express this in a consistent way with everything else, you would have to > > make this QemuOpts-like so it would look like > > > > -monitor control,device=tcp:localhost:444,server > > > > But so far, the monitor, serial, parallel, etc. devices don't take > > QemuOpts. > > > > OTH, having: > > > > -qmp tcp:localhost:444,server > > I think we should create a new option for monitor configuration, like this: > > -mon mode={control,readline},chardev=<name>,more-options-here > > So you'll create a qmp monitor socket this way: > > -chardev socket,path=/tmp/qmpsock,id=qmp,server,nowait > -mon mode=control,chardev=qmp > > Then the -monitor switch will be legacy/convinience syntax for a > readline monitor with auto-created chardev named 'monitor<nr>'. I like this. I believe it wouldn't be difficult for you to rebase your series on top of staging with an incremental patch for QMP, right?