On Thu, Oct 31, 2013 at 3:36 PM, Andreas Färber <afaer...@suse.de> wrote: > Am 31.10.2013 15:31, schrieb Peter Maydell: >> On 31 October 2013 14:18, Andreas Färber <afaer...@suse.de> wrote: >>> Peter, since I had picked up the first two patches into my still pending >>> qom-next pull, as per the QEMU Summit discussion those patches should've >>> gotten an Acked-by. >> >> Hmm? I don't recall this part of the discussion. If you want the >> patches to have an Acked-by from you you need to send mail >> to the list with an Acked-by line. > > No, I added a Signed-off-by. It was clearly stated that a Reviewed-by > needs to be explicitly sent as reply but that "looks okay" should in > exactly such a case where sender=submaintainer should be recorded as > Acked-by, and Sob is certainly stronger than Acked-by. Cf. minutes.
Nope. If you want there to be an Acked-by, say "Acked-by:". Don't make people infer your Acked-bys. And adding tags is a nice-to-have. There is no "rule" stating that you must include everyone that appears on the mailing list. But I expect that maintainers try to Regards, Anthony Liguori > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >