On 12/07/2009 06:32 PM, Anthony Liguori wrote:
If we apply the patch, the callers are no longer incorrect. Since
we're winding down development on that tree, I see no reason for the
production build to be correct and the development tree to be incorrect.
The problem with this whole discussion is taking the position that one
form is "correct" while the other form is "incorrect". It's not so
black and white.
I don't think a reasonable person can claim that either form of
qemu_malloc() is absolutely correct while the other is incorrect. You
may think one is better than the other but clearly, that sentiment is
not universally shared.
I'm less concerned about qemu_malloc() and more about qemu itself
(though qemu_malloc() as patched fulfils all the standard's requirements).
If we change the production build, we eliminate the immediate problem.
What about developers that hit the assert? Do they send patches that
fix code that works in production just so they can run in developer mode?
For 0.13, we can reduce the usage of qemu_malloc() such that it stops
becoming an issue. Then no one ever has to agree about which form is
better and we can move on with our lives.
I agree, and the proposed changes are an improvement in their own right.
--
error compiling committee.c: too many arguments to function