On 12/17/2013 05:26 PM, Juan Quintela wrote:
Result was always 0, and not used anywhere. Once there, use bool type for the parameter.Signed-off-by: Juan Quintela <quint...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> --- exec.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index ba5989c..d165fd8 100644 --- a/exec.c +++ b/exec.c @@ -56,7 +56,7 @@ //#define DEBUG_SUBPAGE #if !defined(CONFIG_USER_ONLY) -static int in_migration; +static bool in_migration; RAMList ram_list = { .blocks = QTAILQ_HEAD_INITIALIZER(ram_list.blocks) }; @@ -751,11 +751,9 @@ void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t length, } } -static int cpu_physical_memory_set_dirty_tracking(int enable) +static void cpu_physical_memory_set_dirty_tracking(bool enable) { - int ret = 0; in_migration = enable; - return ret; } hwaddr memory_region_section_get_iotlb(CPUArchState *env, @@ -1797,12 +1795,12 @@ static void tcg_commit(MemoryListener *listener) static void core_log_global_start(MemoryListener *listener) { - cpu_physical_memory_set_dirty_tracking(1); + cpu_physical_memory_set_dirty_tracking(true); } static void core_log_global_stop(MemoryListener *listener) { - cpu_physical_memory_set_dirty_tracking(0); + cpu_physical_memory_set_dirty_tracking(false); } static MemoryListener core_memory_listener = {
Reviewed-by: Orit Wasserman <owass...@redhat.com>
