Am 24.02.2014 14:51, schrieb Peter Maydell: > On 24 February 2014 13:44, Kevin Wolf <kw...@redhat.com> wrote: >> Am 24.02.2014 um 14:24 hat Peter Maydell geschrieben: >>> On 24 February 2014 10:17, Kevin Wolf <kw...@redhat.com> wrote: >>>> Not sure if I understand the problem. Why is it bad to depend on >>>> windows.h? >>> >>> It drags in an enormous pile of stuff that grabs a lot of >>> namespace that it would be nice to not have to avoid by >>> fiddling with QEMU code. (For instance the Spitz board >>> clashes with a MOD_SHIFT #define.) >> >> Right, I can understand that you want to avoid device models or other >> random source files to have a polluted namespace. >> >> The file that I'm CCed for, however, is block/raw-aio.h, which is only >> included in the raw-posix block driver (there it's #ifdef'ed away) and >> in the raw-win32 one (which has an obvious dependency on Windows >> headers). > > Yes, there doesn't seem too much point in that particular case. > >> Can't see how dropping the type safety improves anything there. I might >> see the improvement of not polluting the namespace in other places, but >> am still not convinced that using void* instead of specific types is a >> good idea. > > We might be able to abstract away the differences into a > QEMU-defined type in some cases rather than using void*. > (I haven't looked to see if this is feasible.) > > thanks > -- PMM >
Kevin, I'll have a look on that special case in v2 of my patch series. I'll say more on type safety and Peter's suggestion in another mail. Stefan
