Am 25.02.2014 00:07, schrieb Stefan Weil: > Am 24.02.2014 14:07, schrieb Andreas Färber: >> Am 23.02.2014 18:02, schrieb Stefan Weil: >>> These header files are used by most QEMU source files. If they >>> depend on windows.h, all those source files do so, too. >>> > [...] >> >> First of all, why was I not CC'ed on this change? >> File is listed under "CPU" subsystem in MAINTAINERS. >> >> Patches not getting sufficient review is one risk, causing merge >> conflicts another. People should be aware of changes you make in their >> files, even if "just" Windows-related. > > Sorry, I simply missed your name in the lengthy output from > get_maintainer.pl. > >> I had moved the field unchanged from another header, I believe. I don't >> think this is a good change (assuming the Windows API is still using >> this type and not void*), especially since it's #ifdef'ed anyway. > > Please see my mail to Kevin (which will be sent in a moment).
My opinion still stands. You can easily add "typedef void * HANDLE;" to qemu-typedefs.h or osdep.h to retain telling type names, in this case explaining why the variable is called "hThread" - h for "HANDLE". Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
