On Fri, Apr 11, 2014 at 01:50:57PM -0400, Luiz Capitulino wrote: > On Sun, 30 Mar 2014 11:58:22 +0100 > Hani Benhabiles <kroo...@gmail.com> wrote: > > > This patch series adds a new callback to mon_cmd_t which will make adding > > completion support for more commands cleaner. > > > > It then adds full or partial arguments completion for multiple hmp commands. > > I was half-way through this series when something occurred to me: what > about merging only the existing completions first? I think that that can > be merged faster because it won't require other people's reviews and > discussions on new completions won't hold the entire series. > > If you agree, please repost it and I'll try to review it quicker. >
Ok, no problem. Will resend shortly. > > > > Changes since v1: > > * Splitting patch 1/7 to 1/17, 2/17 and 3/17. > > * Changed command_completion's first argument from Monitor to > > ReadLineState. > > * Added new commands completions (10/17 to 17/17) > > > > > > Hani Benhabiles (17): > > monitor: Fix drive_del id argument type completion. > > monitor: Add command_completion callback to mon_cmd_t. > > monitor: Add device_add and device_del completion. > > monitor: Add chardev-remove id argument completion. > > monitor: Add chardev-add backend argument completion. > > monitor: Add cpu index argument completion. > > monitor: Add set_link arguments completion. > > monitor: Add netdev_add type argument completion. > > monitor: Add netdev_del id argument completion. > > monitor: Add ringbuf_write and ringbuf_read argument completion. > > monitor: Add watchdog_action argument completion. > > monitor: Add migrate_set_capability completion. > > monitor: Add host_net_add device argument completion. > > readline: Make completion strings always unique. > > monitor: Add host_net_remove arguments completion. > > monitor: Add mouse_set index argument completion. > > monitor: Add delvm and loadvm argument completion. > > > > hmp-commands.hx | 25 +++- > > hmp.h | 23 +++ > > include/sysemu/char.h | 3 +- > > monitor.c | 397 > > +++++++++++++++++++++++++++++++++++++++++++++++--- > > net/net.c | 2 +- > > qemu-char.c | 2 +- > > util/readline.c | 6 + > > 7 files changed, 432 insertions(+), 26 deletions(-) > > >
