On 05/31/2014 05:50 AM, Benoît Canet wrote: > This hudge chainsawing series sit on top of my quorum maintenance series. > > It extract commons definition and block definition into separate files.
I'm not sure if you had to split it quite so fine (a series of three commits, one per file, might have been okay); but doing it one commit per function does make each individual patch easy to review. > > -qapi/common.json contains some definition required by all qapi modules > -qapi/block-core.json contains core qapi block definition usable without the > emulation > code. > -qapi/block.json is a superset of the previous usable with emulation > > Transaction where left appart because they relies on internal snapshot and > hence > cannot be included in block-core.json for now. > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
