The Wednesday 04 Jun 2014 à 16:34:14 (+0200), Stefan Hajnoczi wrote : > On Sat, May 31, 2014 at 01:50:39PM +0200, Benoît Canet wrote: > > This hudge chainsawing series sit on top of my quorum maintenance series. > > > > It extract commons definition and block definition into separate files. > > > > -qapi/common.json contains some definition required by all qapi modules > > -qapi/block-core.json contains core qapi block definition usable without > > the emulation > > code. > > -qapi/block.json is a superset of the previous usable with emulation > > > > Transaction where left appart because they relies on internal snapshot and > > hence > > cannot be included in block-core.json for now. > > I'm fine with this, it's mostly a mechanical change. > > But please squash it down into just a few patches: > > 1. Extract block-core.json and include it. > 2. Extract block.json and include it.
ok, > > I also suggest you drop the quorum maintenance command dependency > because rebasing this series will be no fun. This way you minimize > churn. We can merge this qapi series very quickly, while the quorum > maintenance series may require more discussion. I don't mind rebasing this QAPI series 10 times as I don't need I before 2.2. Right now the only thing that interest me is getting the quorum maintainance series in. Best regards Benoît > > Stefan >