On 06/13/2014 01:25 PM, Eric Blake wrote: > On 06/05/2014 06:22 AM, Wenchao Xia wrote: >> Signed-off-by: Wenchao Xia <wenchaoq...@gmail.com> >> --- >> Makefile | 12 ++++++++---- >> qapi-schema.json | 2 ++ >> 2 files changed, 10 insertions(+), 4 deletions(-) >> create mode 100644 qapi-event.json >>
>> diff --git a/qapi-event.json b/qapi-event.json >> new file mode 100644 >> index 0000000..e69de29 > > Probably better to name this file qapi/event.json, to go alongside the > other sub-files we have already created. Also, I forgot to mention - adding an empty file to qemu.git is unusual. When you respin, make the file non-empty by at least giving it a decent comment at the top stating the purpose of the file. You could even add in a copyright/license comment, if we had any agreement on what to use (but that's already a different thread, since I already pointed out on Benoit's work to split out several .json files that we don't have any example to choose from). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
